Convert project to use RelativePath where appropriate. #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the project to use
RelativePathwhere it is more appropriate thanPath.Relative paths have consistent directory separators, and platform-neutral serialization (helps when converting to JSON). They are converted into
Paths throughRelativePath::to_path, which is provided the path that they are relative to.This means that some of the awkward "convert back to relative path, or a platform neutral variant" patterns can be avoided (stop using
path_to_root,normalize_path, and probably more that I haven't cleaned up yet).This will also help with #589 since relative paths can easily be normalized to determine if a link destination exists or not.
I've compiled both editions of the rust book, and the example project. And both come up with a no-op diff.